Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d1c7e29e authored by Gwendal Grignou's avatar Gwendal Grignou Committed by Jiri Kosina
Browse files

HID: i2c-hid: prevent buffer overflow in early IRQ 



Before ->start() is called, bufsize size is set to HID_MIN_BUFFER_SIZE,
64 bytes. While processing the IRQ, we were asking to receive up to
wMaxInputLength bytes, which can be bigger than 64 bytes.

Later, when ->start is run, a proper bufsize will be calculated.

Given wMaxInputLength is said to be unreliable in other part of the
code, set to receive only what we can even if it results in truncated
reports.

Signed-off-by: default avatarGwendal Grignou <gwendal@chromium.org>
Reviewed-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent dff67416

drivers/hid/i2c-hid/i2c-hid.c

+1 −1
Original line number Diff line number Diff line
@@ -369,7 +369,7 @@ static int i2c_hid_hwreset(struct i2c_client *client) 
static void i2c_hid_get_input(struct i2c_hid *ihid)

{

	int ret, ret_size;

	int size = le16_to_cpu(ihid->hdesc.wMaxInputLength);

	int size = ihid->bufsize;



	ret = i2c_master_recv(ihid->client, ihid->inbuf, size);

	if (ret != size) {