Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0733d2e authored by Marcus Meissner's avatar Marcus Meissner Committed by David S. Miller
Browse files

net/ipv4: Check for mistakenly passed in non-IPv4 address 



Check against mistakenly passing in IPv6 addresses (which would result
in an INADDR_ANY bind) or similar incompatible sockaddrs.

Signed-off-by: default avatarMarcus Meissner <meissner@suse.de>
Cc: Reinhard Max <max@suse.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 948252cb

net/ipv4/af_inet.c

+3 −0
Original line number Original line Diff line number Diff line
@@ -465,6 +465,9 @@ int inet_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) 
	if (addr_len < sizeof(struct sockaddr_in))

	if (addr_len < sizeof(struct sockaddr_in))

		goto out;

		goto out;





	if (addr->sin_family != AF_INET)

		goto out;



	chk_addr_ret = inet_addr_type(sock_net(sk), addr->sin_addr.s_addr);

	chk_addr_ret = inet_addr_type(sock_net(sk), addr->sin_addr.s_addr);





	/* Not specified by any standard per-se, however it breaks too

	/* Not specified by any standard per-se, however it breaks too