Commit c8cf89f7 authored Jul 11, 2015 by Florian Fainelli Committed by David S. Miller Jul 11, 2015

net: dsa: Fix off-by-one in switch address parsing



cd->sw_addr is used as a MDIO bus address, which cannot exceed
PHY_MAX_ADDR (32), our check was off-by-one.

Fixes: 5e95329b ("dsa: add device tree bindings to register DSA switches")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8f5063e9

net/dsa/dsa.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -630,7 +630,7 @@ static int dsa_of_probe(struct device *dev)
		continue;

		cd->sw_addr = be32_to_cpup(sw_addr);
		if (cd->sw_addr > PHY_MAX_ADDR)
		if (cd->sw_addr >= PHY_MAX_ADDR)
		continue;

		if (!of_property_read_u32(child, "eeprom-length", &eeprom_len))