Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bc41ae15 authored by Oliver Neukum's avatar Oliver Neukum Committed by Greg Kroah-Hartman
Browse files

CDC-ACM: heed quirk also in error handling 



commit 97fe809934dd2b0b37dfef3a2fc70417f485d7af upstream.

If buffers are iterated over in the error case, the lower limits
for quirky devices must be heeded.

Signed-off-by: default avatarOliver Neukum <oneukum@suse.com>
Reported-by: default avatarJean Rene Dawin <jdawin@math.uni-bielefeld.de>
Fixes: a4e7279cd1d19 ("cdc-acm: introduce a cool down")
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200526124420.22160-1-oneukum@suse.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b9e0cdab

drivers/usb/class/cdc-acm.c

+1 −1
Original line number Diff line number Diff line
@@ -602,7 +602,7 @@ static void acm_softint(struct work_struct *work) 
	}



	if (test_and_clear_bit(ACM_ERROR_DELAY, &acm->flags)) {

		for (i = 0; i < ACM_NR; i++)

		for (i = 0; i < acm->rx_buflimit; i++)

			if (test_and_clear_bit(i, &acm->urbs_in_error_delay))

					acm_submit_read_urb(acm, i, GFP_NOIO);

	}