Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a08ef476 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

tipc: uninitialized return code in tipc_setsockopt() 



We shuffled some code around and added some new case statements here and
now "res" isn't initialized on all paths.

Fixes: 01fd12bb ("tipc: make replicast a user selectable option")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1045ba77

net/tipc/socket.c

+1 −2
Original line number Diff line number Diff line
@@ -2348,7 +2348,7 @@ static int tipc_setsockopt(struct socket *sock, int lvl, int opt, 
	struct sock *sk = sock->sk;

	struct tipc_sock *tsk = tipc_sk(sk);

	u32 value = 0;

	int res;

	int res = 0;



	if ((lvl == IPPROTO_TCP) && (sock->type == SOCK_STREAM))

		return 0;
@@ -2388,7 +2388,6 @@ static int tipc_setsockopt(struct socket *sock, int lvl, int opt, 
		break;

	case TIPC_CONN_TIMEOUT:

		tipc_sk(sk)->conn_timeout = value;

		/* no need to set "res", since already 0 at this point */

		break;

	case TIPC_MCAST_BROADCAST:

		tsk->mc_method.rcast = false;