Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7ee015e0 authored Oct 10, 2007 by Denis V. Lunev Committed by David S. Miller Oct 10, 2007

[NET]: cleanup 3rd argument in netlink_sendskb



netlink_sendskb does not use third argument. Clean it and save a couple of
bytes.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Acked-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3b71535f

include/linux/netlink.h

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -194,7 +194,7 @@ struct sock netlink_getsockbyfilp(struct file filp);
	int netlink_attachskb(struct sock sk, struct sk_buff skb, int nonblock,		int netlink_attachskb(struct sock sk, struct sk_buff skb, int nonblock,
	long timeo, struct sock *ssk);		long timeo, struct sock *ssk);
	void netlink_detachskb(struct sock sk, struct sk_buff skb);		void netlink_detachskb(struct sock sk, struct sk_buff skb);
	int netlink_sendskb(struct sock sk, struct sk_buff skb, int protocol);		int netlink_sendskb(struct sock sk, struct sk_buff skb);

	/*		/*
	* skb should fit one page. This choice is good for headerless malloc.		* skb should fit one page. This choice is good for headerless malloc.

ipc/mqueue.c

+2 −3

Original line number	Original line	Diff line number	Diff line
	@@ -521,8 +521,7 @@ static void __do_notify(struct mqueue_inode_info *info)
	break;		break;
	case SIGEV_THREAD:		case SIGEV_THREAD:
	set_cookie(info->notify_cookie, NOTIFY_WOKENUP);		set_cookie(info->notify_cookie, NOTIFY_WOKENUP);
	netlink_sendskb(info->notify_sock,		netlink_sendskb(info->notify_sock, info->notify_cookie);
	info->notify_cookie, 0);
	break;		break;
	}		}
	/* after notification unregisters process */		/* after notification unregisters process */
	@@ -568,7 +567,7 @@ static void remove_notification(struct mqueue_inode_info *info)
	if (info->notify_owner != NULL &&		if (info->notify_owner != NULL &&
	info->notify.sigev_notify == SIGEV_THREAD) {		info->notify.sigev_notify == SIGEV_THREAD) {
	set_cookie(info->notify_cookie, NOTIFY_REMOVED);		set_cookie(info->notify_cookie, NOTIFY_REMOVED);
	netlink_sendskb(info->notify_sock, info->notify_cookie, 0);		netlink_sendskb(info->notify_sock, info->notify_cookie);
	}		}
	put_pid(info->notify_owner);		put_pid(info->notify_owner);
	info->notify_owner = NULL;		info->notify_owner = NULL;

net/netlink/af_netlink.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -791,7 +791,7 @@ int netlink_attachskb(struct sock sk, struct sk_buff skb, int nonblock,
	return 0;		return 0;
	}		}

	int netlink_sendskb(struct sock sk, struct sk_buff skb, int protocol)		int netlink_sendskb(struct sock sk, struct sk_buff skb)
	{		{
	int len = skb->len;		int len = skb->len;

	@@ -853,7 +853,7 @@ int netlink_unicast(struct sock ssk, struct sk_buff skb, u32 pid, int nonblock
	if (err)		if (err)
	return err;		return err;

	return netlink_sendskb(sk, skb, ssk->sk_protocol);		return netlink_sendskb(sk, skb);
	}		}

	int netlink_has_listeners(struct sock *sk, unsigned int group)		int netlink_has_listeners(struct sock *sk, unsigned int group)