Commit 6d9fd099 authored Mar 07, 2019 by Greg Kroah-Hartman Committed by Alistair Delva Jan 13, 2020

UPSTREAM: kcov: no need to check return value of debugfs_create functions

(Upstream commit ec9672d57670d495404f36ab8b651bfefc0ea10b.)

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Link: http://lkml.kernel.org/r/20190122152151.16139-46-gregkh@linuxfoundation.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Anders Roxell <anders.roxell@linaro.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Bug: 147413187
Change-Id: I8ed5dc6aeba3dda8b91ceea4fed5cd9ef058461f

parent 37638f9a

kernel/kcov.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -444,10 +444,8 @@ static int __init kcov_init(void)
		* there is no need to protect it against removal races. The
		* use of debugfs_create_file_unsafe() is actually safe here.
		*/
		if (!debugfs_create_file_unsafe("kcov", 0600, NULL, NULL, &kcov_fops)) {
		pr_err("failed to create kcov in debugfs\n");
		return -ENOMEM;
		}
		debugfs_create_file_unsafe("kcov", 0600, NULL, NULL, &kcov_fops);

		return 0;
		}