Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c371578 authored by Jan Kara's avatar Jan Kara
Browse files

udf: Fix lost indirect extent block



When inode ends with empty indirect extent block and we extended that
file, udf_do_extend_file() ended up just overwriting pointer to it with
another extent and thus effectively leaking the block and also
corruptiong length of allocation descriptors.

Fix the problem by properly following into next indirect extent when it
is present.

Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent fcea62ba
Loading
Loading
Loading
Loading
+10 −1
Original line number Diff line number Diff line
@@ -539,9 +539,18 @@ static int udf_do_extend_file(struct inode *inode,
		udf_add_aext(inode, last_pos, &last_ext->extLocation,
			     last_ext->extLength, 1);
		count++;
	} else
	} else {
		struct kernel_lb_addr tmploc;
		uint32_t tmplen;

		udf_write_aext(inode, last_pos, &last_ext->extLocation,
				last_ext->extLength, 1);
		/*
		 * We've rewritten the last extent but there may be empty
		 * indirect extent after it - enter it.
		 */
		udf_next_aext(inode, last_pos, &tmploc, &tmplen, 0);
	}

	/* Managed to do everything necessary? */
	if (!blocks)