Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 674e405b authored by J. Bruce Fields's avatar J. Bruce Fields Committed by Trond Myklebust
Browse files

nfs: document nfsv4 sillyrename issues 



Somebody working on this code asked what the deal was with NFSv4, since
this comment notes that it's v2/v3's statelessness that requires
sillyrename.  Shouldn't hurt to document the answer.

Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent 94b134ac

fs/nfs/unlink.c

+8 −0
Original line number Original line Diff line number Diff line
@@ -501,6 +501,14 @@ nfs_async_rename(struct inode *old_dir, struct inode *new_dir, 
 * and only performs the unlink once the last reference to it is put.

 * and only performs the unlink once the last reference to it is put.

 *

 *

 * The final cleanup is done during dentry_iput.

 * The final cleanup is done during dentry_iput.

 *

 * (Note: NFSv4 is stateful, and has opens, so in theory an NFSv4 server

 * could take responsibility for keeping open files referenced.  The server

 * would also need to ensure that opened-but-deleted files were kept over

 * reboots.  However, we may not assume a server does so.  (RFC 5661

 * does provide an OPEN4_RESULT_PRESERVE_UNLINKED flag that a server can

 * use to advertise that it does this; some day we may take advantage of

 * it.))

 */

 */

int

int

nfs_sillyrename(struct inode *dir, struct dentry *dentry)

nfs_sillyrename(struct inode *dir, struct dentry *dentry)