Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f6a7e5e authored by Sage Weil's avatar Sage Weil
Browse files

ceph: update support for PGID64, PGPOOL3, OSDENC protocol features 



Support (and require) the PGID64, PGPOOL3, and OSDENC protocol features.
These have been present in ceph.git since v0.42, Feb 2012.  Require these
features to simplify support; nobody is running older userspace.

Note that the new request and reply encoding is still not in place, so the new
code is not yet functional.

Signed-off-by: default avatarSage Weil <sage@inktank.com>
Reviewed-by: default avatarAlex Elder <elder@inktank.com>
parent ec73a754

fs/ceph/mdsmap.c

+8 −4
Original line number Diff line number Diff line
@@ -59,6 +59,10 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end) 
		return ERR_PTR(-ENOMEM);



	ceph_decode_16_safe(p, end, version, bad);

	if (version > 3) {

		pr_warning("got mdsmap version %d > 3, failing", version);

		goto bad;

	}



	ceph_decode_need(p, end, 8*sizeof(u32) + sizeof(u64), bad);

	m->m_epoch = ceph_decode_32(p);
@@ -144,13 +148,13 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end) 
	/* pg_pools */

	ceph_decode_32_safe(p, end, n, bad);

	m->m_num_data_pg_pools = n;

	m->m_data_pg_pools = kcalloc(n, sizeof(u32), GFP_NOFS);

	m->m_data_pg_pools = kcalloc(n, sizeof(u64), GFP_NOFS);

	if (!m->m_data_pg_pools)

		goto badmem;

	ceph_decode_need(p, end, sizeof(u32)*(n+1), bad);

	ceph_decode_need(p, end, sizeof(u64)*(n+1), bad);

	for (i = 0; i < n; i++)

		m->m_data_pg_pools[i] = ceph_decode_32(p);

	m->m_cas_pg_pool = ceph_decode_32(p);

		m->m_data_pg_pools[i] = ceph_decode_64(p);

	m->m_cas_pg_pool = ceph_decode_64(p);



	/* ok, we don't care about the rest. */

	dout("mdsmap_decode success epoch %u\n", m->m_epoch);

include/linux/ceph/ceph_features.h

+10 −4
Original line number Diff line number Diff line
@@ -40,10 +40,16 @@ 
 */

#define CEPH_FEATURES_SUPPORTED_DEFAULT  \

	(CEPH_FEATURE_NOSRCADDR |		\

	 CEPH_FEATURE_PGID64 |			\

	 CEPH_FEATURE_PGPOOL3 |			\

	 CEPH_FEATURE_OSDENC |			\

	 CEPH_FEATURE_CRUSH_TUNABLES |		\

	 CEPH_FEATURE_CRUSH_TUNABLES2 |		\

	 CEPH_FEATURE_REPLY_CREATE_INODE)



#define CEPH_FEATURES_REQUIRED_DEFAULT   \

	(CEPH_FEATURE_NOSRCADDR)

	(CEPH_FEATURE_NOSRCADDR |	 \

	 CEPH_FEATURE_PGID64 |		 \

	 CEPH_FEATURE_PGPOOL3 |		 \

	 CEPH_FEATURE_OSDENC)

#endif

include/linux/ceph/mdsmap.h

+2 −2
Original line number Diff line number Diff line
@@ -29,8 +29,8 @@ struct ceph_mdsmap { 


	/* which object pools file data can be stored in */

	int m_num_data_pg_pools;

	u32 *m_data_pg_pools;

	u32 m_cas_pg_pool;

	u64 *m_data_pg_pools;

	u64 m_cas_pg_pool;

};



static inline struct ceph_entity_addr *

include/linux/ceph/osdmap.h

+13 −3
Original line number Diff line number Diff line
@@ -25,12 +25,22 @@ struct ceph_pg { 


struct ceph_pg_pool_info {

	struct rb_node node;

	int id;

	struct ceph_pg_pool v;

	int pg_num_mask, pgp_num_mask, lpg_num_mask, lpgp_num_mask;

	s64 id;

	u8 type;

	u8 size;

	u8 crush_ruleset;

	u8 object_hash;

	u32 pg_num, pgp_num;

	int pg_num_mask, pgp_num_mask;

	u64 flags;

	char *name;

};



struct ceph_object_locator {

	uint64_t pool;

	char *key;

};



struct ceph_pg_mapping {

	struct rb_node node;

	struct ceph_pg pgid;

include/linux/ceph/rados.h

+0 −23
Original line number Diff line number Diff line
@@ -8,14 +8,6 @@ 


#include <linux/ceph/msgr.h>



/*

 * osdmap encoding versions

 */

#define CEPH_OSDMAP_INC_VERSION     5

#define CEPH_OSDMAP_INC_VERSION_EXT 6

#define CEPH_OSDMAP_VERSION         5

#define CEPH_OSDMAP_VERSION_EXT     6



/*

 * fs id

 */
@@ -91,21 +83,6 @@ struct ceph_pg_v1 { 


#define CEPH_PG_TYPE_REP     1

#define CEPH_PG_TYPE_RAID4   2

#define CEPH_PG_POOL_VERSION 2

struct ceph_pg_pool {

	__u8 type;                /* CEPH_PG_TYPE_* */

	__u8 size;                /* number of osds in each pg */

	__u8 crush_ruleset;       /* crush placement rule */

	__u8 object_hash;         /* hash mapping object name to ps */

	__le32 pg_num, pgp_num;   /* number of pg's */

	__le32 lpg_num, lpgp_num; /* number of localized pg's */

	__le32 last_change;       /* most recent epoch changed */

	__le64 snap_seq;          /* seq for per-pool snapshot */

	__le32 snap_epoch;        /* epoch of last snap */

	__le32 num_snaps;

	__le32 num_removed_snap_intervals; /* if non-empty, NO per-pool snaps */

	__le64 auid;               /* who owns the pg */

} __attribute__ ((packed));



/*

 * stable_mod func is used to control number of placement groups.