Commit 423f5c0d authored Dec 28, 2009 by Dan Carpenter Committed by Mauro Carvalho Chehab Jan 17, 2010

V4L/DVB (13955): cx25821: fix double unlock in medusa_video_init()



medusa_set_videostandard() takes the lock but it always drops it before
returning.

This was found with a static checker and compile tested only.  :/

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent c4240509

drivers/staging/cx25821/cx25821-medusa-video.c

+1 −3

Original line number	Original line	Diff line number	Diff line
	@@ -860,10 +860,8 @@ int medusa_video_init(struct cx25821_dev *dev)

	ret_val = medusa_set_videostandard(dev);		ret_val = medusa_set_videostandard(dev);

	if (ret_val < 0) {		if (ret_val < 0)
	mutex_unlock(&dev->lock);
	return -EINVAL;		return -EINVAL;
	}

	return 1;		return 1;
	}		}