Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 40212054 authored by Vinayak Menon's avatar Vinayak Menon Committed by Gerrit - the friendly Code Review server
Browse files

android: lowmemorykiller: disable ALMK during memory offline 



Make lowmemorykiller aware of memory offline and disable adaptive
lowmemorykiller (ALMK) during the offline process. This reduces the
unnecessary kills during offlining. ALMK is meant to improve app
launch performances, thus not something to be run during offlining.

Change-Id: I3bde808cf18db76a787d0a4e864d1d8693f4885b
Signed-off-by: default avatarVinayak Menon <vinmenon@codeaurora.org>
parent 5542ee99

drivers/staging/android/lowmemorykiller.c

+35 −3
Original line number Diff line number Diff line
@@ -49,6 +49,7 @@ 
#include <linux/cpuset.h>

#include <linux/vmpressure.h>

#include <linux/freezer.h>

#include <linux/memory.h>



#define CREATE_TRACE_POINTS

#include <trace/events/almk.h>
@@ -111,8 +112,14 @@ static atomic_t shift_adj = ATOMIC_INIT(0); 
static short adj_max_shift = 353;

module_param_named(adj_max_shift, adj_max_shift, short, 0644);



enum {

	ADAPTIVE_LMK_DISABLED = 0,

	ADAPTIVE_LMK_ENABLED,

	ADAPTIVE_LMK_WAS_ENABLED,

};



/* User knob to enable/disable adaptive lmk feature */

static int enable_adaptive_lmk;

static int enable_adaptive_lmk = ADAPTIVE_LMK_DISABLED;

module_param_named(enable_adaptive_lmk, enable_adaptive_lmk, int, 0644);



/*
@@ -153,7 +160,7 @@ static int adjust_minadj(short *min_score_adj) 
{

	int ret = VMPRESSURE_NO_ADJUST;



	if (!enable_adaptive_lmk)

	if (enable_adaptive_lmk != ADAPTIVE_LMK_ENABLED)

		return 0;



	if (atomic_read(&shift_adj) &&
@@ -176,7 +183,7 @@ static int lmk_vmpressure_notifier(struct notifier_block *nb, 
	unsigned long pressure = action;

	int array_size = ARRAY_SIZE(lowmem_adj);



	if (!enable_adaptive_lmk)

	if (enable_adaptive_lmk != ADAPTIVE_LMK_ENABLED)

		return 0;



	if (pressure >= 95) {
@@ -678,16 +685,41 @@ static unsigned long lowmem_scan(struct shrinker *s, struct shrink_control *sc) 
	return rem;

}



static int lmk_hotplug_callback(struct notifier_block *self,

				unsigned long action, void *arg)

{

	switch (action) {

	case MEM_GOING_OFFLINE:

		if (enable_adaptive_lmk == ADAPTIVE_LMK_ENABLED)

			enable_adaptive_lmk = ADAPTIVE_LMK_WAS_ENABLED;

		break;

	case MEM_OFFLINE:

		if (enable_adaptive_lmk == ADAPTIVE_LMK_WAS_ENABLED)

			enable_adaptive_lmk = ADAPTIVE_LMK_ENABLED;

		break;

	default:

		break;

	}

	return NOTIFY_OK;

}



static struct shrinker lowmem_shrinker = {

	.scan_objects = lowmem_scan,

	.count_objects = lowmem_count,

	.seeks = DEFAULT_SEEKS * 16

};



static struct notifier_block lmk_memory_callback_nb = {

	.notifier_call = lmk_hotplug_callback,

	.priority = 0,

};



static int __init lowmem_init(void)

{

	register_shrinker(&lowmem_shrinker);

	vmpressure_notifier_register(&lmk_vmpr_nb);

	if (register_hotmemory_notifier(&lmk_memory_callback_nb))

		lowmem_print(1, "Registering memory hotplug notifier failed\n");

	return 0;

}

device_initcall(lowmem_init);