Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3dcc2c3b authored by Henrique de Moraes Holschuh's avatar Henrique de Moraes Holschuh Committed by Len Brown
Browse files

thinkpad-acpi: cleanup debug helpers 



Fix the vdbg_printk macro definition to be sane when
CONFIG_THINKPAD_ACPI_DEBUG is undefined, and move the mess into a file
section of its own.

This doesn't change anything in the current code, but future code will
need the proper behaviour.

Signed-off-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 078ac19e

drivers/platform/x86/thinkpad_acpi.c

+18 −11
Original line number Diff line number Diff line
@@ -184,17 +184,6 @@ enum { 
#define TPACPI_DBG_ALL		0xffff

#define TPACPI_DBG_INIT		0x0001

#define TPACPI_DBG_EXIT		0x0002

#define dbg_printk(a_dbg_level, format, arg...) \

	do { if (dbg_level & a_dbg_level) \

		printk(TPACPI_DEBUG "%s: " format, __func__ , ## arg); \

	} while (0)

#ifdef CONFIG_THINKPAD_ACPI_DEBUG

#define vdbg_printk(a_dbg_level, format, arg...) \

	dbg_printk(a_dbg_level, format, ## arg)

static const char *str_supported(int is_supported);

#else

#define vdbg_printk(a_dbg_level, format, arg...)

#endif



#define onoff(status, bit) ((status) & (1 << (bit)) ? "on" : "off")

#define enabled(status, bit) ((status) & (1 << (bit)) ? "enabled" : "disabled")
@@ -326,6 +315,24 @@ static int tpacpi_uwb_emulstate; 
#endif





/*************************************************************************

 *  Debugging helpers

 */



#define dbg_printk(a_dbg_level, format, arg...) \

	do { if (dbg_level & (a_dbg_level)) \

		printk(TPACPI_DEBUG "%s: " format, __func__ , ## arg); \

	} while (0)



#ifdef CONFIG_THINKPAD_ACPI_DEBUG

#define vdbg_printk dbg_printk

static const char *str_supported(int is_supported);

#else

#define vdbg_printk(a_dbg_level, format, arg...) \

	do { } while (0)

#endif





/****************************************************************************

 ****************************************************************************

 *