Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3608c66c authored by Vivek Kutal's avatar Vivek Kutal Committed by Linus Torvalds
Browse files

fbdev: *bfin*: drop unnecessary calls to memset 



The dma_alloc_* functions sets the memory to 0 before returning so there
is no need to call memset after the allocation.  Also no point in clearing
the memory when disabling the buffer.

Signed-off-by: default avatarVivek Kutal <vivek.kutal@azingo.com>
Signed-off-by: default avatarMike Frysinger <vapier@gentoo.org>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 9990bfd0

drivers/video/bf54x-lq043fb.c

+0 −3
Original line number Diff line number Diff line
@@ -323,7 +323,6 @@ static int bfin_bf54x_fb_release(struct fb_info *info, int user) 
		bfin_write_EPPI0_CONTROL(0);

		SSYNC();

		disable_dma(CH_EPPI0);

		memset(fbi->fb_buffer, 0, info->fix.smem_len);

	}



	spin_unlock(&fbi->lock);
@@ -626,8 +625,6 @@ static int __init bfin_bf54x_probe(struct platform_device *pdev) 
		goto out3;

	}



	memset(info->fb_buffer, 0, fbinfo->fix.smem_len);



	fbinfo->screen_base = (void *)info->fb_buffer;

	fbinfo->fix.smem_start = (int)info->fb_buffer;

drivers/video/bfin-t350mcqb-fb.c

+0 −3
Original line number Diff line number Diff line
@@ -242,7 +242,6 @@ static int bfin_t350mcqb_fb_release(struct fb_info *info, int user) 
		SSYNC();

		disable_dma(CH_PPI);

		bfin_t350mcqb_stop_timers();

		memset(fbi->fb_buffer, 0, info->fix.smem_len);

	}



	spin_unlock(&fbi->lock);
@@ -527,8 +526,6 @@ static int __devinit bfin_t350mcqb_probe(struct platform_device *pdev) 
		goto out3;

	}



	memset(info->fb_buffer, 0, fbinfo->fix.smem_len);



	fbinfo->screen_base = (void *)info->fb_buffer + ACTIVE_VIDEO_MEM_OFFSET;

	fbinfo->fix.smem_start = (int)info->fb_buffer + ACTIVE_VIDEO_MEM_OFFSET;