Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 34fa78b5 authored by Andreas Schwab's avatar Andreas Schwab Committed by Geert Uytterhoeven
Browse files

m68k: fix sigset_t accessor functions 



The sigaddset/sigdelset/sigismember functions that are implemented with
bitfield insn cannot allow the sigset argument to be placed in a data
register since the sigset is wider than 32 bits.  Remove the "d"
constraint from the asm statements.

The effect of the bug is that sending RT signals does not work, the signal
number is truncated modulo 32.

Signed-off-by: default avatarAndreas Schwab <schwab@linux-m68k.org>
Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Cc: stable@vger.kernel.org
parent f4a75d2e

arch/m68k/include/asm/signal.h

+3 −3
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ struct k_sigaction { 
static inline void sigaddset(sigset_t *set, int _sig)

{

	asm ("bfset %0{%1,#1}"

		: "+od" (*set)

		: "+o" (*set)

		: "id" ((_sig - 1) ^ 31)

		: "cc");

}
@@ -49,7 +49,7 @@ static inline void sigaddset(sigset_t *set, int _sig) 
static inline void sigdelset(sigset_t *set, int _sig)

{

	asm ("bfclr %0{%1,#1}"

		: "+od" (*set)

		: "+o" (*set)

		: "id" ((_sig - 1) ^ 31)

		: "cc");

}
@@ -65,7 +65,7 @@ static inline int __gen_sigismember(sigset_t *set, int _sig) 
	int ret;

	asm ("bfextu %1{%2,#1},%0"

		: "=d" (ret)

		: "od" (*set), "id" ((_sig-1) ^ 31)

		: "o" (*set), "id" ((_sig-1) ^ 31)

		: "cc");

	return ret;

}