Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2fc2b484 authored by Dan Carpenter's avatar Dan Carpenter Committed by Lee Jones
Browse files

mfd: dln2: A couple endian fixes 



Sparse catches a couple endian bugs.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarOctavian Purdila <octavian.purdila@intel.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 00ee7a37

drivers/mfd/dln2.c

+5 −3
Original line number Diff line number Diff line
@@ -436,6 +436,7 @@ static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd, 
	struct device *dev = &dln2->interface->dev;

	const unsigned long timeout = DLN2_USB_TIMEOUT * HZ / 1000;

	struct dln2_mod_rx_slots *rxs = &dln2->mod_rx_slots[handle];

	int size;



	spin_lock(&dln2->disconnect_lock);

	if (!dln2->disconnect)
@@ -477,8 +478,9 @@ static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd, 


	/* if we got here we know that the response header has been checked */

	rsp = rxc->urb->transfer_buffer;

	size = le16_to_cpu(rsp->hdr.size);



	if (rsp->hdr.size < sizeof(*rsp)) {

	if (size < sizeof(*rsp)) {

		ret = -EPROTO;

		goto out_free_rx_slot;

	}
@@ -493,8 +495,8 @@ static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd, 
	if (!ibuf)

		goto out_free_rx_slot;



	if (*ibuf_len > rsp->hdr.size - sizeof(*rsp))

		*ibuf_len = rsp->hdr.size - sizeof(*rsp);

	if (*ibuf_len > size - sizeof(*rsp))

		*ibuf_len = size - sizeof(*rsp);



	memcpy(ibuf, rsp + 1, *ibuf_len);