Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2d4ba4a3 authored by Randy Dunlap's avatar Randy Dunlap Committed by Linus Torvalds
Browse files

[PATCH] ucb1400_ts depends SND_AC97_BUS



This driver is an AC97 codec according to its help text.  However, if SOUND is
disabled, the "select SND_AC97_BUS" still inserts that into the .config file:

#
# Sound
#
# CONFIG_SOUND is not set
CONFIG_SND_AC97_BUS=m

Even if the config software followed dependency chains on selects, we should
try to limit usage of "select" to library-type code that is needed (e.g., CRC
functions) instead of bus-type support.

Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent db9a758c
Loading
Loading
Loading
Loading
+1 −1
Original line number Original line Diff line number Diff line
@@ -146,7 +146,7 @@ config TOUCHSCREEN_TOUCHWIN


config TOUCHSCREEN_UCB1400
config TOUCHSCREEN_UCB1400
	tristate "Philips UCB1400 touchscreen"
	tristate "Philips UCB1400 touchscreen"
	select SND_AC97_BUS
	depends on SND_AC97_BUS
	help
	help
	  This enables support for the Philips UCB1400 touchscreen interface.
	  This enables support for the Philips UCB1400 touchscreen interface.
	  The UCB1400 is an AC97 audio codec.  The touchscreen interface
	  The UCB1400 is an AC97 audio codec.  The touchscreen interface