Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1f4c17a0 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

SUNRPC: Handle EADDRNOTAVAIL on connection failures 



If the connect attempt immediately fails with an EADDRNOTAVAIL error, then
that means our choice of source port number was bad.
This error is expected when we set the SO_REUSEPORT socket option and we
have 2 sockets sharing the same source and destination address and port
combinations.

Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
Fixes: 402e23b4 ("SUNRPC: Fix stupid typo in xs_sock_set_reuseport")
Cc: stable@vger.kernel.org # v4.0+
parent 944171cb

net/sunrpc/xprtsock.c

+4 −0
Original line number Original line Diff line number Diff line
@@ -2295,6 +2295,10 @@ static int xs_tcp_finish_connecting(struct rpc_xprt *xprt, struct socket *sock) 
		/* SYN_SENT! */

		/* SYN_SENT! */

		if (xprt->reestablish_timeout < XS_TCP_INIT_REEST_TO)

		if (xprt->reestablish_timeout < XS_TCP_INIT_REEST_TO)

			xprt->reestablish_timeout = XS_TCP_INIT_REEST_TO;

			xprt->reestablish_timeout = XS_TCP_INIT_REEST_TO;

		break;

	case -EADDRNOTAVAIL:

		/* Source port number is unavailable. Try a new one! */

		transport->srcport = 0;

	}

	}

out:

out:

	return ret;

	return ret;