Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1309d7af authored by Peter Huewe's avatar Peter Huewe Committed by Linus Torvalds
Browse files

char/tpm: Fix unitialized usage of data buffer 



This patch fixes information leakage to the userspace by initializing
the data buffer to zero.

Reported-by: default avatarPeter Huewe <huewe.external@infineon.com>
Signed-off-by: default avatarPeter Huewe <huewe.external@infineon.com>
Signed-off-by: default avatarMarcel Selhorst <m.selhorst@sirrix.com>
[ Also removed the silly "* sizeof(u8)".  If that isn't 1, we have way
  deeper problems than a simple multiplication can fix.   - Linus ]
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0444d76a

drivers/char/tpm/tpm.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -980,7 +980,7 @@ int tpm_open(struct inode *inode, struct file *file) 
		return -EBUSY;

		return -EBUSY;

	}

	}





	chip->data_buffer = kmalloc(TPM_BUFSIZE * sizeof(u8), GFP_KERNEL);

	chip->data_buffer = kzalloc(TPM_BUFSIZE, GFP_KERNEL);

	if (chip->data_buffer == NULL) {

	if (chip->data_buffer == NULL) {

		clear_bit(0, &chip->is_open);

		clear_bit(0, &chip->is_open);

		put_device(chip->dev);

		put_device(chip->dev);