Commit 107b02c8 authored Nov 14, 2017 by Lior David Committed by Greg Kroah-Hartman Dec 05, 2018

wil6210: missing length check in wmi_set_ie



commit b5a8ffcae4103a9d823ea3aa3a761f65779fbe2a upstream.

Add a length check in wmi_set_ie to detect unsigned integer
overflow.

Signed-off-by: Lior David <qca_liord@qca.qualcomm.com>
Signed-off-by: Maya Erez <qca_merez@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 39d9e1c6

drivers/net/wireless/ath/wil6210/wmi.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -1380,8 +1380,14 @@ int wmi_set_ie(struct wil6210_priv wil, u8 type, u16 ie_len, const void ie)
		};
		int rc;
		u16 len = sizeof(struct wmi_set_appie_cmd) + ie_len;
		struct wmi_set_appie_cmd *cmd = kzalloc(len, GFP_KERNEL);
		struct wmi_set_appie_cmd *cmd;

		if (len < ie_len) {
		rc = -EINVAL;
		goto out;
		}

		cmd = kzalloc(len, GFP_KERNEL);
		if (!cmd) {
		rc = -ENOMEM;
		goto out;