Commit 0e1c32ea authored Mar 25, 2019 by Rama Aparna Mallavarapu Committed by Gerrit - the friendly Code Review server Jul 22, 2019

devfreq: bw_mon: check for the return value of start_monitor



The BWMON governor start is returning success on GOV_START event
without checking for the return value of start_monitor.
The return value of start_monitor is not being returned to
ret variable. This would cause the governor to start successfully
even when the monitor failed to start causing a NULL pointer
derefence when accessing the device attributes. Fix it by checking
the return value of start_monitor.

Change-Id: I8c1f6933d44ae4533c6b81ccda8a5c4c0da3779c
Signed-off-by: Rama Aparna Mallavarapu <aparnam@codeaurora.org>

parent 9efefd8a

drivers/devfreq/governor_bw_hwmon.c

+3 −2

Original line number	Diff line number	Diff line
		/*
		* Copyright (c) 2013-2018, The Linux Foundation. All rights reserved.
		* Copyright (c) 2013-2019, The Linux Foundation. All rights reserved.
		*
		* This program is free software; you can redistribute it and/or modify
		* it under the terms of the GNU General Public License version 2 and
		@@ -617,7 +617,8 @@ static int gov_start(struct devfreq *df)
		node->orig_data = df->data;
		df->data = node;

		if (start_monitor(df, true))
		ret = start_monitor(df, true);
		if (ret)
		goto err_start;

		ret = sysfs_create_group(&df->dev.kobj, node->attr_grp);