Commit 088f93d0 authored Sep 18, 2019 by Bjorn Andersson Committed by Greg Kroah-Hartman Oct 05, 2019

net: qrtr: Stop rx_worker before freeing node



[ Upstream commit 73f0c11d11329a0d6d205d4312b6e5d2512af7c5 ]

As the endpoint is unregistered there might still be work pending to
handle incoming messages, which will result in a use after free
scenario. The plan is to remove the rx_worker, but until then (and for
stable@) ensure that the work is stopped before the node is freed.

Fixes: bdabad3e ("net: Add Qualcomm IPC router")
Cc: stable@vger.kernel.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8b831b69

net/qrtr/qrtr.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -129,6 +129,7 @@ static void __qrtr_node_release(struct kref *kref)
		list_del(&node->item);
		mutex_unlock(&qrtr_node_lock);

		cancel_work_sync(&node->work);
		skb_queue_purge(&node->rx_queue);
		kfree(node);
		}