Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ffa1e4ed authored by Grazvydas Ignotas's avatar Grazvydas Ignotas Committed by Tony Lindgren
Browse files

ARM: OMAP: fix erroneous mmc2 clock change on mmc3 setup 



hsmmc23_before_set_reg() can set MMCSDIO2ADPCLKISEL bit, which
enables internal clock for MMC2. Currently this function is also called
by code handling MMC3, and if .internal_clock is set in platform data
(by default it currently is), it will set MMCSDIO2ADPCLKISEL for MMC2
instead of MMC3 (MMC3 doesn't have such bit so nothing actually needs to
be done). This breaks 2nd SD slot on pandora.

Fix this by changing hsmmc23_before_set_reg() to only handle MMC2.
Note that this removes .remux() call for MMC3, but no board currently
needs it and it's also not called for MMC4 and MMC5.

Signed-off-by: default avatarGrazvydas Ignotas <notasas@gmail.com>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent 8ef5d844

arch/arm/mach-omap2/hsmmc.c

+3 −4
Original line number Diff line number Diff line
@@ -182,7 +182,7 @@ static void hsmmc2_select_input_clk_src(struct omap_mmc_platform_data *mmc) 
	}

}



static void hsmmc23_before_set_reg(struct device *dev, int slot,

static void hsmmc2_before_set_reg(struct device *dev, int slot,

				   int power_on, int vdd)

{

	struct omap_mmc_platform_data *mmc = dev->platform_data;
@@ -407,14 +407,13 @@ static int __init omap_hsmmc_pdata_init(struct omap2_hsmmc_info *c, 
			c->caps &= ~MMC_CAP_8_BIT_DATA;

			c->caps |= MMC_CAP_4_BIT_DATA;

		}

		/* FALLTHROUGH */

	case 3:

		if (mmc->slots[0].features & HSMMC_HAS_PBIAS) {

			/* off-chip level shifting, or none */

			mmc->slots[0].before_set_reg = hsmmc23_before_set_reg;

			mmc->slots[0].before_set_reg = hsmmc2_before_set_reg;

			mmc->slots[0].after_set_reg = NULL;

		}

		break;

	case 3:

	case 4:

	case 5:

		mmc->slots[0].before_set_reg = NULL;