Commit feb27d15 authored Mar 05, 2015 by Dan Carpenter Committed by David S. Miller Mar 06, 2015

ax25: remove unneeded NULL test in ax_xmit()



We get a static checker warning here on devel kernels:

	drivers/net/hamradio/mkiss.c:560 ax_xmit()
	warn: variable dereferenced before check 'skb' (see line 532)

It turns out that the NULL check can be deleted.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f68a8ebd

drivers/net/hamradio/mkiss.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -557,11 +557,9 @@ static netdev_tx_t ax_xmit(struct sk_buff skb, struct net_device dev)
		}

		/* We were not busy, so we are now... :-) */
		if (skb != NULL) {
		netif_stop_queue(dev);
		ax_encaps(dev, skb->data, skb->len);
		kfree_skb(skb);
		}

		return NETDEV_TX_OK;
		}