Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit feacdb4a authored by Ray Jui's avatar Ray Jui Committed by Bjorn Helgaas
Browse files

PCI: iproc: Fix incorrect MSI address alignment 



In the code to handle PAXB v2 based MSI steering, the logic aligns the MSI
register address to the size of supported inbound mapping range.  This is
incorrect since it rounds "up" the starting address to the next aligned
address, but what we want is the starting address to be rounded "down" to
the aligned address.

This patch fixes the issue and allows MSI writes to be properly steered to
the GIC.

Fixes: 4b073155fbd3 ("PCI: iproc: Add support for the next-gen PAXB controller")
Signed-off-by: default avatarRay Jui <ray.jui@broadcom.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent c7c44527

drivers/pci/host/pcie-iproc.c

+1 −1
Original line number Diff line number Diff line
@@ -1020,7 +1020,7 @@ static int iproc_pcie_paxb_v2_msi_steer(struct iproc_pcie *pcie, u64 msi_addr) 


	memset(&range, 0, sizeof(range));

	range.size = SZ_32K;

	range.pci_addr = range.cpu_addr = ALIGN(msi_addr, range.size);

	range.pci_addr = range.cpu_addr = msi_addr & ~(range.size - 1);



	ret = iproc_pcie_setup_ib(pcie, &range, IPROC_PCIE_IB_MAP_IO);

	return ret;