Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fd133593 authored by Benjamin Gaignard's avatar Benjamin Gaignard Committed by Greg Kroah-Hartman
Browse files

staging: ion: simplify ioctl args checking function 



Make arguments checking more easy to read.

Signed-off-by: default avatarBenjamin Gaignard <benjamin.gaignard@linaro.org>
Acked-by: default avatarLaura Abbott <labbott@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 198277f2

drivers/staging/android/ion/ion-ioctl.c

+5 −6
Original line number Diff line number Diff line
@@ -27,19 +27,18 @@ union ion_ioctl_arg { 


static int validate_ioctl_arg(unsigned int cmd, union ion_ioctl_arg *arg)

{

	int ret = 0;



	switch (cmd) {

	case ION_IOC_HEAP_QUERY:

		ret = arg->query.reserved0 != 0;

		ret |= arg->query.reserved1 != 0;

		ret |= arg->query.reserved2 != 0;

		if (arg->query.reserved0 ||

		    arg->query.reserved1 ||

		    arg->query.reserved2 )

			return -EINVAL;

		break;

	default:

		break;

	}



	return ret ? -EINVAL : 0;

	return 0;

}



/* fix up the cases where the ioctl direction bits are incorrect */