Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fcfc762f authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

greybus: connection: kill gb_hd_connections_exit 



Connections are destroyed as part of interface tear down. If we fail to
do that properly it's a bug that should be fixed rather than papered
over by a fall-back clean up function.

Signed-off-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent 5245a905

drivers/staging/greybus/connection.c

+0 −8
Original line number Diff line number Diff line
@@ -489,14 +489,6 @@ void gb_connection_latency_tag_disable(struct gb_connection *connection) 
}

EXPORT_SYMBOL_GPL(gb_connection_latency_tag_disable);



void gb_hd_connections_exit(struct greybus_host_device *hd)

{

	struct gb_connection *connection;



	list_for_each_entry(connection, &hd->connections, hd_links)

		gb_connection_destroy(connection);

}



int gb_connection_bind_protocol(struct gb_connection *connection)

{

	struct gb_protocol *protocol;

drivers/staging/greybus/connection.h

+0 −1
Original line number Diff line number Diff line
@@ -58,7 +58,6 @@ struct gb_connection *gb_connection_create_range(struct greybus_host_device *hd, 
			   u16 cport_id, u8 protocol_id, u32 ida_start,

			   u32 ida_end);

void gb_connection_destroy(struct gb_connection *connection);

void gb_hd_connections_exit(struct greybus_host_device *hd);



void greybus_data_rcvd(struct greybus_host_device *hd, u16 cport_id,

			u8 *data, size_t length);

drivers/staging/greybus/core.c

+0 −6
Original line number Diff line number Diff line
@@ -242,12 +242,6 @@ void greybus_remove_hd(struct greybus_host_device *hd) 
	if (hd->initial_svc_connection)

		gb_connection_destroy(hd->initial_svc_connection);



	/*

	 * Make sure there are no leftovers that can potentially corrupt sysfs.

	 */

	if (WARN_ON(!list_empty(&hd->connections)))

		gb_hd_connections_exit(hd);



	kref_put_mutex(&hd->kref, free_hd, &hd_mutex);

}

EXPORT_SYMBOL_GPL(greybus_remove_hd);