Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa72d661 authored by Felix Kuehling's avatar Felix Kuehling Committed by Oded Gabbay
Browse files

drm/amdgpu: remove useless BUG_ONs 



Dereferencing NULL pointers will cause a BUG anyway. No need to do
an explicit check.

Signed-off-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
parent 30d13424

drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c

+0 −6
Original line number Diff line number Diff line
@@ -212,10 +212,6 @@ int alloc_gtt_mem(struct kgd_dev *kgd, size_t size, 
	struct kgd_mem **mem = (struct kgd_mem **) mem_obj;

	int r;



	BUG_ON(kgd == NULL);

	BUG_ON(gpu_addr == NULL);

	BUG_ON(cpu_ptr == NULL);



	*mem = kmalloc(sizeof(struct kgd_mem), GFP_KERNEL);

	if ((*mem) == NULL)

		return -ENOMEM;
@@ -269,8 +265,6 @@ void free_gtt_mem(struct kgd_dev *kgd, void *mem_obj) 
{

	struct kgd_mem *mem = (struct kgd_mem *) mem_obj;



	BUG_ON(mem == NULL);



	amdgpu_bo_reserve(mem->bo, true);

	amdgpu_bo_kunmap(mem->bo);

	amdgpu_bo_unpin(mem->bo);

drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c

+0 −2
Original line number Diff line number Diff line
@@ -812,8 +812,6 @@ static uint16_t get_fw_version(struct kgd_dev *kgd, enum kgd_engine_type type) 
	struct amdgpu_device *adev = (struct amdgpu_device *) kgd;

	const union amdgpu_firmware_header *hdr;



	BUG_ON(kgd == NULL);



	switch (type) {

	case KGD_ENGINE_PFP:

		hdr = (const union amdgpu_firmware_header *)

drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c

+0 −2
Original line number Diff line number Diff line
@@ -775,8 +775,6 @@ static uint16_t get_fw_version(struct kgd_dev *kgd, enum kgd_engine_type type) 
	struct amdgpu_device *adev = (struct amdgpu_device *) kgd;

	const union amdgpu_firmware_header *hdr;



	BUG_ON(kgd == NULL);



	switch (type) {

	case KGD_ENGINE_PFP:

		hdr = (const union amdgpu_firmware_header *)