Commit fa2b5ea0 authored Oct 15, 2013 by Linus Walleij Committed by Greg Kroah-Hartman Oct 16, 2013

serial: core: delete .set_wake() callback



This deletes the .set_wake() callback in the struct uart_ops.
Apparently this has been unused since pre-git times. In the
old-2.6-bkcvs it is deleted as part of a changeset removing
the PM_SET_WAKEUP from pm_request_t which is since also deleted
from the kernel.

The apropriate way to set wakeups in the kernel is to have a
code snippet like this in .suspend() or .runtime_suspend()
callbacks:

static int foo_suspend(struct device *dev)
{
	if (device_may_wakeup(dev)) {
		/* Enable wakeups, set internal states */
	}
}

This specific callback is not coming back.

Cc: Rafael J. Wysocki <rjw@sisk.pl>
Cc: Len Brown <len.brown@intel.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Dmitry Artamonow <mad_soft@inbox.ru>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 35925010

Documentation/serial/driver

+0 −4

Original line number	Diff line number	Diff line
		@@ -264,10 +264,6 @@ hardware.
		Locking: none.
		Interrupts: caller dependent.

		set_wake(port,state)
		Enable/disable power management wakeup on serial activity. Not
		currently implemented.

		type(port)
		Return a pointer to a string constant describing the specified
		port, or return NULL, in which case the string 'unknown' is

include/linux/serial_core.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -66,7 +66,6 @@ struct uart_ops {
		void (set_ldisc)(struct uart_port , int new);
		void (pm)(struct uart_port , unsigned int state,
		unsigned int oldstate);
		int (set_wake)(struct uart_port , unsigned int state);

		/*
		* Return a string describing the type of the port