Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa160828 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

sparc32: off by ones in BUG_ON() 



Smatch complains that these tests are off by one, which is true but not
life threatening.

	arch/sparc/kernel/irq_32.c:169 irq_link()
	error: buffer overflow 'irq_map' 384 <= 384

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4f6deb8c

arch/sparc/kernel/irq_32.c

+2 −2
Original line number Diff line number Diff line
@@ -165,7 +165,7 @@ void irq_link(unsigned int irq) 


	p = &irq_table[irq];

	pil = p->pil;

	BUG_ON(pil > SUN4D_MAX_IRQ);

	BUG_ON(pil >= SUN4D_MAX_IRQ);

	p->next = irq_map[pil];

	irq_map[pil] = p;
@@ -182,7 +182,7 @@ void irq_unlink(unsigned int irq) 
	spin_lock_irqsave(&irq_map_lock, flags);



	p = &irq_table[irq];

	BUG_ON(p->pil > SUN4D_MAX_IRQ);

	BUG_ON(p->pil >= SUN4D_MAX_IRQ);

	pnext = &irq_map[p->pil];

	while (*pnext != p)

		pnext = &(*pnext)->next;