Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f779b2d6 authored by Zheng Yan's avatar Zheng Yan Committed by David S. Miller
Browse files

tcp: fix validation of D-SACK



D-SACK is allowed to reside below snd_una. But the corresponding check
in tcp_is_sackblock_valid() is the exact opposite. It looks like a typo.

Signed-off-by: default avatarZheng Yan <zheng.z.yan@intel.com>
Acked-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e05c82d3
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -1124,7 +1124,7 @@ static int tcp_is_sackblock_valid(struct tcp_sock *tp, int is_dsack,
		return 0;

	/* ...Then it's D-SACK, and must reside below snd_una completely */
	if (!after(end_seq, tp->snd_una))
	if (after(end_seq, tp->snd_una))
		return 0;

	if (!before(start_seq, tp->undo_marker))