Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f44e2659 authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Jani Nikula
Browse files

drm/i915: Fix crtc_y assignment in intel_find_initial_plane_obj() 



Let's set crtc_y to 0 instead of setting src_y twice.

Multiple assignments in one statement is a good way to hide bugs.
Please don't do that.

Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Fixes: be5651f2 ("drm/i915: Update missing properties in find_initial_plane_obj")
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1447434973-12369-1-git-send-email-ville.syrjala@linux.intel.com


Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
parent 8005c49d

drivers/gpu/drm/i915/intel_display.c

+4 −2
Original line number Diff line number Diff line
@@ -2646,11 +2646,13 @@ intel_find_initial_plane_obj(struct intel_crtc *intel_crtc, 
	return;



valid_fb:

	plane_state->src_x = plane_state->src_y = 0;

	plane_state->src_x = 0;

	plane_state->src_y = 0;

	plane_state->src_w = fb->width << 16;

	plane_state->src_h = fb->height << 16;



	plane_state->crtc_x = plane_state->src_y = 0;

	plane_state->crtc_x = 0;

	plane_state->crtc_y = 0;

	plane_state->crtc_w = fb->width;

	plane_state->crtc_h = fb->height;