Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f3ee9096 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Mark Brown
Browse files

ASoC: topology: Fix a potential memory leak in 'soc_tplg_dapm_widget_denum_create()' 



If this sanity check fails, we must free the memory that has already been
allocated.

So we must go to 'err' as in the other error handling parth of this
function.

Fixes: 1a7dd6e2 ("ASoC: topology: Allow a widget to have multiple enum controls")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 6d5574ed

sound/soc/soc-topology.c

+1 −1
Original line number Diff line number Diff line
@@ -1301,7 +1301,7 @@ static struct snd_kcontrol_new *soc_tplg_dapm_widget_denum_create( 
		/* validate kcontrol */

		if (strnlen(ec->hdr.name, SNDRV_CTL_ELEM_ID_NAME_MAXLEN) ==

			    SNDRV_CTL_ELEM_ID_NAME_MAXLEN)

			return NULL;

			goto err;



		se = kzalloc(sizeof(*se), GFP_KERNEL);

		if (se == NULL)