Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f3ed653c authored by Alexander Duyck's avatar Alexander Duyck Committed by David S. Miller
Browse files

net/mlx5e: Fix IPv6 tunnel checksum offload 



The mlx5 driver exposes support for TSO6 but not IPv6 csum for hardware
encapsulated tunnels.  This leads to issues as it triggers warnings in
skb_checksum_help as it ends up being called as we report supporting the
segmentation but not the checksumming for IPv6 frames.

This patch corrects that and drops 2 features that don't actually need to
be supported in hw_enc_features since they are Rx features and don't
actually impact anything by being present in hw_enc_features.

Signed-off-by: default avatarAlexander Duyck <aduyck@mirantis.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b49663c8

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

+1 −2
Original line number Diff line number Diff line
@@ -2806,10 +2806,9 @@ static void mlx5e_build_netdev(struct net_device *netdev) 
					   NETIF_F_GSO_UDP_TUNNEL_CSUM |

					   NETIF_F_GSO_PARTIAL;

		netdev->hw_enc_features |= NETIF_F_IP_CSUM;

		netdev->hw_enc_features |= NETIF_F_RXCSUM;

		netdev->hw_enc_features |= NETIF_F_IPV6_CSUM;

		netdev->hw_enc_features |= NETIF_F_TSO;

		netdev->hw_enc_features |= NETIF_F_TSO6;

		netdev->hw_enc_features |= NETIF_F_RXHASH;

		netdev->hw_enc_features |= NETIF_F_GSO_UDP_TUNNEL;

		netdev->hw_enc_features |= NETIF_F_GSO_UDP_TUNNEL_CSUM |

					   NETIF_F_GSO_PARTIAL;