Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f3851b0a authored by Ben Hutchings's avatar Ben Hutchings
Browse files

sfc: Fix lookup of default RX MAC filters when steered using ethtool 



commit 385904f8 ('sfc: Don't use
efx_filter_{build,hash,increment}() for default MAC filters') used the
wrong name to find the index of default RX MAC filters at insertion/
update time.  This could result in memory corruption and would in any
case silently fail to update the filter.

Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
parent 0f7dd1aa

drivers/net/ethernet/sfc/filter.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -675,7 +675,7 @@ s32 efx_filter_insert_filter(struct efx_nic *efx, struct efx_filter_spec *spec, 
		BUILD_BUG_ON(EFX_FILTER_INDEX_UC_DEF != 0);

		BUILD_BUG_ON(EFX_FILTER_INDEX_UC_DEF != 0);

		BUILD_BUG_ON(EFX_FILTER_INDEX_MC_DEF !=

		BUILD_BUG_ON(EFX_FILTER_INDEX_MC_DEF !=

			     EFX_FILTER_MC_DEF - EFX_FILTER_UC_DEF);

			     EFX_FILTER_MC_DEF - EFX_FILTER_UC_DEF);

		rep_index = spec->type - EFX_FILTER_INDEX_UC_DEF;

		rep_index = spec->type - EFX_FILTER_UC_DEF;

		ins_index = rep_index;

		ins_index = rep_index;





		spin_lock_bh(&state->lock);

		spin_lock_bh(&state->lock);