Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f1640c3d authored by wangweidong's avatar wangweidong Committed by David S. Miller
Browse files

bgmac: fix a missing check for build_skb 



when build_skb failed, it may occure a NULL pointer.
So add a 'NULL check' for it.

Signed-off-by: default avatarWeidong Wang <wangweidong1@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ddb5388f

drivers/net/ethernet/broadcom/bgmac.c

+5 −0
Original line number Diff line number Diff line
@@ -466,6 +466,11 @@ static int bgmac_dma_rx_read(struct bgmac *bgmac, struct bgmac_dma_ring *ring, 
			len -= ETH_FCS_LEN;



			skb = build_skb(buf, BGMAC_RX_ALLOC_SIZE);

			if (unlikely(skb)) {

				bgmac_err(bgmac, "build_skb failed\n");

				put_page(virt_to_head_page(buf));

				break;

			}

			skb_put(skb, BGMAC_RX_FRAME_OFFSET +

				BGMAC_RX_BUF_OFFSET + len);

			skb_pull(skb, BGMAC_RX_FRAME_OFFSET +