Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit efd65379 authored by Mike Snitzer's avatar Mike Snitzer Committed by Greg Kroah-Hartman
Browse files

dm linear: eliminate linear_end_io call if CONFIG_DM_ZONED disabled 



commit beb9caac upstream.

It is best to avoid any extra overhead associated with bio completion.
DM core will indirectly call a DM target's .end_io if it is defined.
In the case of DM linear, there is no need to do so (for every bio that
completes) if CONFIG_DM_ZONED is not enabled.

Avoiding an extra indirect call for every bio completion is very
important for ensuring DM linear doesn't incur more overhead that
further widens the performance gap between dm-linear and raw block
devices.

Fixes: 0be12c1c ("dm linear: add support for zoned block devices")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 261f2cba

drivers/md/dm-linear.c

+7 −1
Original line number Diff line number Diff line
@@ -101,6 +101,7 @@ static int linear_map(struct dm_target *ti, struct bio *bio) 
	return DM_MAPIO_REMAPPED;

}



#ifdef CONFIG_DM_ZONED

static int linear_end_io(struct dm_target *ti, struct bio *bio,

			 blk_status_t *error)

{
@@ -111,6 +112,7 @@ static int linear_end_io(struct dm_target *ti, struct bio *bio, 


	return DM_ENDIO_DONE;

}

#endif



static void linear_status(struct dm_target *ti, status_type_t type,

			  unsigned status_flags, char *result, unsigned maxlen)
@@ -187,12 +189,16 @@ static size_t linear_dax_copy_from_iter(struct dm_target *ti, pgoff_t pgoff, 
static struct target_type linear_target = {

	.name   = "linear",

	.version = {1, 4, 0},

#ifdef CONFIG_DM_ZONED

	.end_io = linear_end_io,

	.features = DM_TARGET_PASSES_INTEGRITY | DM_TARGET_ZONED_HM,

#else

	.features = DM_TARGET_PASSES_INTEGRITY,

#endif

	.module = THIS_MODULE,

	.ctr    = linear_ctr,

	.dtr    = linear_dtr,

	.map    = linear_map,

	.end_io = linear_end_io,

	.status = linear_status,

	.prepare_ioctl = linear_prepare_ioctl,

	.iterate_devices = linear_iterate_devices,