Commit ef2c8326 authored Nov 23, 2012 by Sylwester Nawrocki Committed by Mauro Carvalho Chehab Dec 21, 2012

[media] s5p-csis: Correct the event counters logging



The counter field is unsigned so >= 0 condition always evaluates
to true. Fix this to log events for which counter is > 0 or for
all when in debug mode.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 1bc05e77

drivers/media/platform/s5p-fimc/mipi-csis.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -401,12 +401,12 @@ static void s5pcsis_log_counters(struct csis_state *state, bool non_errors)

		spin_lock_irqsave(&state->slock, flags);

		for (i--; i >= 0; i--)
		if (state->events[i].counter >= 0)
		for (i--; i >= 0; i--) {
		if (state->events[i].counter > 0 \|\| debug)
		v4l2_info(&state->sd, "%s events: %d\n",
		state->events[i].name,
		state->events[i].counter);

		}
		spin_unlock_irqrestore(&state->slock, flags);
		}