Commit ec76f400 authored Mar 12, 2015 by Alexey Kardashevskiy Committed by Alex Williamson Mar 12, 2015

vfio-pci: Add missing break to enable VFIO_PCI_ERR_IRQ_INDEX



This adds a missing break statement to VFIO_DEVICE_SET_IRQS handler
without which vfio_pci_set_err_trigger() would never be called.

While we are here, add another "break" to VFIO_PCI_REQ_IRQ_INDEX case
so if we add more indexes later, we won't miss it.

Fixes: 6140a8f5 ("vfio-pci: Add device request interface")
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

parent 9eccca08

drivers/vfio/pci/vfio_pci_intrs.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -868,12 +868,14 @@ int vfio_pci_set_irqs_ioctl(struct vfio_pci_device *vdev, uint32_t flags,
		func = vfio_pci_set_err_trigger;
		break;
		}
		break;
		case VFIO_PCI_REQ_IRQ_INDEX:
		switch (flags & VFIO_IRQ_SET_ACTION_TYPE_MASK) {
		case VFIO_IRQ_SET_ACTION_TRIGGER:
		func = vfio_pci_set_req_trigger;
		break;
		}
		break;
		}

		if (!func)