Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eb351031 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Tejun Heo
Browse files

ahci: qoriq: Fix a compiling warning 



kbuild test robot reports the warnings:
drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset':
>> include/asm-generic/io.h:163:2: warning: 'px_is' may be used
>> uninitialized in this function [-Wuninitialized]
drivers/ata/ahci_qoriq.c:70:14: note: 'px_is' was declared here
>> include/asm-generic/io.h:163:2: warning: 'px_cmd' may be used
>> uninitialized in this function [-Wuninitialized]
drivers/ata/ahci_qoriq.c:70:6: note: 'px_cmd' was declared here

This patch fixed it by introducing a local variable.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarTang Yuantian <Yuantian.Tang@freescale.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 3a53b3bc

drivers/ata/ahci_qoriq.c

+3 −2
Original line number Diff line number Diff line
@@ -76,6 +76,7 @@ static int ahci_qoriq_hardreset(struct ata_link *link, unsigned int *class, 
	struct ata_taskfile tf;

	bool online;

	int rc;

	bool ls1021a_workaround = (qoriq_priv->type == AHCI_LS1021A);



	DPRINTK("ENTER\n");
@@ -92,7 +93,7 @@ static int ahci_qoriq_hardreset(struct ata_link *link, unsigned int *class, 
	 * After the sequence is complete, software should restore the

	 * PxCMD and PxIS with the stored values.

	 */

	if (qoriq_priv->type == AHCI_LS1021A) {

	if (ls1021a_workaround) {

		px_cmd = readl(port_mmio + PORT_CMD);

		px_is = readl(port_mmio + PORT_IRQ_STAT);

	}
@@ -106,7 +107,7 @@ static int ahci_qoriq_hardreset(struct ata_link *link, unsigned int *class, 
				 ahci_check_ready);



	/* restore the PxCMD and PxIS on ls1021 */

	if (qoriq_priv->type == AHCI_LS1021A) {

	if (ls1021a_workaround) {

		px_val = readl(port_mmio + PORT_CMD);

		if (px_val != px_cmd)

			writel(px_cmd, port_mmio + PORT_CMD);