Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eb31f849 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

igb: use netdev_rss_key_fill() helper 



Use of well known RSS key increases attack surface.
Switch to a random one, using generic helper so that all
ports share a common key.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 22f258a1

drivers/net/ethernet/intel/igb/igb_main.c

+3 −6
Original line number Diff line number Diff line
@@ -3372,14 +3372,11 @@ static void igb_setup_mrqc(struct igb_adapter *adapter) 
	struct e1000_hw *hw = &adapter->hw;

	u32 mrqc, rxcsum;

	u32 j, num_rx_queues;

	static const u32 rsskey[10] = { 0xDA565A6D, 0xC20E5B25, 0x3D256741,

					0xB08FA343, 0xCB2BCAD0, 0xB4307BAE,

					0xA32DCB77, 0x0CF23080, 0x3BB7426A,

					0xFA01ACBE };

	u32 rss_key[10];



	/* Fill out hash function seeds */

	netdev_rss_key_fill(rss_key, sizeof(rss_key));

	for (j = 0; j < 10; j++)

		wr32(E1000_RSSRK(j), rsskey[j]);

		wr32(E1000_RSSRK(j), rss_key[j]);



	num_rx_queues = adapter->rss_queues;