Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e9f51837 authored by Viresh Kumar's avatar Viresh Kumar Committed by Rafael J. Wysocki
Browse files

cpufreq: Don't check if cpu is online/offline for cpufreq callbacks 



cpufreq layer doesn't call cpufreq driver's callback for any offline
CPU and so checking that isn't useful.

Lets get rid of it.

Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Acked-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent b43a7ffb

arch/mips/kernel/cpufreq/loongson2_cpufreq.c

+0 −6
Original line number Diff line number Diff line
@@ -61,9 +61,6 @@ static int loongson2_cpufreq_target(struct cpufreq_policy *policy, 
	struct cpufreq_freqs freqs;

	unsigned int freq;



	if (!cpu_online(cpu))

		return -ENODEV;



	cpus_allowed = current->cpus_allowed;

	set_cpus_allowed_ptr(current, cpumask_of(cpu));
@@ -109,9 +106,6 @@ static int loongson2_cpufreq_cpu_init(struct cpufreq_policy *policy) 
	unsigned long rate;

	int ret;



	if (!cpu_online(policy->cpu))

		return -ENODEV;



	cpuclk = clk_get(NULL, "cpu_clk");

	if (IS_ERR(cpuclk)) {

		printk(KERN_ERR "cpufreq: couldn't get CPU clk\n");

arch/sh/kernel/cpufreq.c

+0 −6
Original line number Diff line number Diff line
@@ -51,9 +51,6 @@ static int sh_cpufreq_target(struct cpufreq_policy *policy, 
	struct device *dev;

	long freq;



	if (!cpu_online(cpu))

		return -ENODEV;



	cpus_allowed = current->cpus_allowed;

	set_cpus_allowed_ptr(current, cpumask_of(cpu));
@@ -111,9 +108,6 @@ static int sh_cpufreq_cpu_init(struct cpufreq_policy *policy) 
	struct cpufreq_frequency_table *freq_table;

	struct device *dev;



	if (!cpu_online(cpu))

		return -ENODEV;



	dev = get_cpu_device(cpu);



	cpuclk = clk_get(dev, "cpu_clk");

arch/sparc/kernel/us2e_cpufreq.c

+0 −6
Original line number Diff line number Diff line
@@ -234,9 +234,6 @@ static unsigned int us2e_freq_get(unsigned int cpu) 
	cpumask_t cpus_allowed;

	unsigned long clock_tick, estar;



	if (!cpu_online(cpu))

		return 0;



	cpumask_copy(&cpus_allowed, tsk_cpus_allowed(current));

	set_cpus_allowed_ptr(current, cpumask_of(cpu));
@@ -257,9 +254,6 @@ static void us2e_set_cpu_divider_index(struct cpufreq_policy *policy, 
	cpumask_t cpus_allowed;

	struct cpufreq_freqs freqs;



	if (!cpu_online(cpu))

		return;



	cpumask_copy(&cpus_allowed, tsk_cpus_allowed(current));

	set_cpus_allowed_ptr(current, cpumask_of(cpu));

arch/sparc/kernel/us3_cpufreq.c

+0 −6
Original line number Diff line number Diff line
@@ -82,9 +82,6 @@ static unsigned int us3_freq_get(unsigned int cpu) 
	unsigned long reg;

	unsigned int ret;



	if (!cpu_online(cpu))

		return 0;



	cpumask_copy(&cpus_allowed, tsk_cpus_allowed(current));

	set_cpus_allowed_ptr(current, cpumask_of(cpu));
@@ -104,9 +101,6 @@ static void us3_set_cpu_divider_index(struct cpufreq_policy *policy, 
	cpumask_t cpus_allowed;

	struct cpufreq_freqs freqs;



	if (!cpu_online(cpu))

		return;



	cpumask_copy(&cpus_allowed, tsk_cpus_allowed(current));

	set_cpus_allowed_ptr(current, cpumask_of(cpu));

drivers/cpufreq/p4-clockmod.c

+1 −2
Original line number Diff line number Diff line
@@ -58,8 +58,7 @@ static int cpufreq_p4_setdc(unsigned int cpu, unsigned int newstate) 
{

	u32 l, h;



	if (!cpu_online(cpu) ||

	    (newstate > DC_DISABLE) || (newstate == DC_RESV))

	if ((newstate > DC_DISABLE) || (newstate == DC_RESV))

		return -EINVAL;



	rdmsr_on_cpu(cpu, MSR_IA32_THERM_STATUS, &l, &h);