Commit e9ed104d authored Jan 01, 2014 by Julia Lawall Committed by Jonathan Cameron Jan 01, 2014

staging:iio:impedance:ad5933: correct error check

iio_kfifo_allocate returns NULL in case of error.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression *x;
identifier f;
statement S1,S2;
@@

*x = f(...);
 if (x) { <+... when != if (...) S1 else S2
     -ENOMEM ...+> }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
cc: stable@vger.kernel.org

parent 83d5f324

drivers/staging/iio/impedance-analyzer/ad5933.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -629,7 +629,7 @@ static int ad5933_register_ring_funcs_and_init(struct iio_dev *indio_dev)
		struct iio_buffer *buffer;

		buffer = iio_kfifo_allocate(indio_dev);
		if (buffer)
		if (!buffer)
		return -ENOMEM;

		iio_device_attach_buffer(indio_dev, buffer);