Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e9083420 authored by Dave Airlie's avatar Dave Airlie
Browse files

drm: introduce sync objects (v4) 



Sync objects are new toplevel drm object, that contain a
pointer to a fence. This fence can be updated via command
submission ioctls via drivers.

There is also a generic wait obj API modelled on the vulkan
wait API (with code modelled on some amdgpu code).

These objects can be converted to an opaque fd that can be
passes between processes.

v2: rename reference/unreference to put/get (Chris)
fix leaked reference (David Zhou)
drop mutex in favour of cmpxchg (Chris)
v3: cleanups from danvet, rebase on drm_fops rename
check fd_flags is 0 in ioctls.
v4: export find/free, change replace fence to take a
syncobj. In order to support lookup first, replace
later semantics which seem in the end to be cleaner.

Reviewed-by: default avatarSean Paul <seanpaul@chromium.org>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent c9f0726f

Documentation/gpu/drm-internals.rst

+3 −0
Original line number Diff line number Diff line
@@ -98,6 +98,9 @@ DRIVER_ATOMIC 
    implement appropriate obj->atomic_get_property() vfuncs for any

    modeset objects with driver specific properties.



DRIVER_SYNCOBJ

    Driver support drm sync objects.



Major, Minor and Patchlevel

~~~~~~~~~~~~~~~~~~~~~~~~~~~

Documentation/gpu/drm-mm.rst

+12 −0
Original line number Diff line number Diff line
@@ -484,3 +484,15 @@ DRM Cache Handling 


.. kernel-doc:: drivers/gpu/drm/drm_cache.c

   :export:



DRM Sync Objects

===========================



.. kernel-doc:: drivers/gpu/drm/drm_syncobj.c

   :doc: Overview



.. kernel-doc:: include/drm/drm_syncobj.h

   :export:



.. kernel-doc:: drivers/gpu/drm/drm_syncobj.c

   :export:

drivers/gpu/drm/Makefile

+2 −1
Original line number Diff line number Diff line
@@ -16,7 +16,8 @@ drm-y := drm_auth.o drm_bufs.o drm_cache.o \ 
		drm_framebuffer.o drm_connector.o drm_blend.o \

		drm_encoder.o drm_mode_object.o drm_property.o \

		drm_plane.o drm_color_mgmt.o drm_print.o \

		drm_dumb_buffers.o drm_mode_config.o drm_vblank.o

		drm_dumb_buffers.o drm_mode_config.o drm_vblank.o \

		drm_syncobj.o



drm-$(CONFIG_DRM_LIB_RANDOM) += lib/drm_random.o

drm-$(CONFIG_DRM_VM) += drm_vm.o

drivers/gpu/drm/drm_file.c

+8 −0
Original line number Diff line number Diff line
@@ -229,6 +229,9 @@ static int drm_open_helper(struct file *filp, struct drm_minor *minor) 
	if (drm_core_check_feature(dev, DRIVER_GEM))

		drm_gem_open(dev, priv);



	if (drm_core_check_feature(dev, DRIVER_SYNCOBJ))

		drm_syncobj_open(priv);



	if (drm_core_check_feature(dev, DRIVER_PRIME))

		drm_prime_init_file_private(&priv->prime);
@@ -276,6 +279,8 @@ static int drm_open_helper(struct file *filp, struct drm_minor *minor) 
out_prime_destroy:

	if (drm_core_check_feature(dev, DRIVER_PRIME))

		drm_prime_destroy_file_private(&priv->prime);

	if (drm_core_check_feature(dev, DRIVER_SYNCOBJ))

		drm_syncobj_release(priv);

	if (drm_core_check_feature(dev, DRIVER_GEM))

		drm_gem_release(dev, priv);

	put_pid(priv->pid);
@@ -398,6 +403,9 @@ int drm_release(struct inode *inode, struct file *filp) 
		drm_property_destroy_user_blobs(dev, file_priv);

	}



	if (drm_core_check_feature(dev, DRIVER_SYNCOBJ))

		drm_syncobj_release(file_priv);



	if (drm_core_check_feature(dev, DRIVER_GEM))

		drm_gem_release(dev, file_priv);

drivers/gpu/drm/drm_internal.h

+13 −0
Original line number Diff line number Diff line
@@ -143,4 +143,17 @@ static inline int drm_debugfs_crtc_crc_add(struct drm_crtc *crtc) 
{

	return 0;

}



#endif



/* drm_syncobj.c */

void drm_syncobj_open(struct drm_file *file_private);

void drm_syncobj_release(struct drm_file *file_private);

int drm_syncobj_create_ioctl(struct drm_device *dev, void *data,

			     struct drm_file *file_private);

int drm_syncobj_destroy_ioctl(struct drm_device *dev, void *data,

			      struct drm_file *file_private);

int drm_syncobj_handle_to_fd_ioctl(struct drm_device *dev, void *data,

				   struct drm_file *file_private);

int drm_syncobj_fd_to_handle_ioctl(struct drm_device *dev, void *data,

				   struct drm_file *file_private);