Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e73a8569 authored by Markus Elfring's avatar Markus Elfring Committed by Rob Clark
Browse files

drm/msm: Delete unnecessary checks before drm_gem_object_unreference_unlocked() 



The drm_gem_object_unreference_unlocked() function tests whether
its argument is NULL and then returns immediately.
Thus the test around the calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarRob Clark <robdclark@gmail.com>
parent 851dd75d

drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c

+1 −2
Original line number Diff line number Diff line
@@ -168,7 +168,6 @@ static void mdp4_destroy(struct msm_kms *kms) 


	if (mdp4_kms->blank_cursor_iova)

		msm_gem_put_iova(mdp4_kms->blank_cursor_bo, mdp4_kms->id);

	if (mdp4_kms->blank_cursor_bo)

	drm_gem_object_unreference_unlocked(mdp4_kms->blank_cursor_bo);



	if (mdp4_kms->rpm_enabled)

drivers/gpu/drm/msm/msm_fb.c

+2 −2
Original line number Diff line number Diff line
@@ -49,7 +49,7 @@ static void msm_framebuffer_destroy(struct drm_framebuffer *fb) 


	for (i = 0; i < n; i++) {

		struct drm_gem_object *bo = msm_fb->planes[i];

		if (bo)



		drm_gem_object_unreference_unlocked(bo);

	}

drivers/gpu/drm/msm/msm_gem.c

+1 −3
Original line number Diff line number Diff line
@@ -875,8 +875,6 @@ struct drm_gem_object *msm_gem_import(struct drm_device *dev, 
	return obj;



fail:

	if (obj)

	drm_gem_object_unreference_unlocked(obj);



	return ERR_PTR(ret);

}