Commit e5d295b0 authored May 31, 2018 by Suman Anna Committed by Rafael J. Wysocki Jun 06, 2018

cpufreq: ti-cpufreq: Fix an incorrect error return value



Commit 05829d94 (cpufreq: ti-cpufreq: kfree opp_data when
failure) has fixed a memory leak in the failure path, however
the patch returned a positive value on get_cpu_device() failure
instead of the previous negative value. Fix this incorrect error
return value properly.

Fixes: 05829d94 (cpufreq: ti-cpufreq: kfree opp_data when failure)
Cc: 4.14+ <stable@vger.kernel.org> # v4.14+
Signed-off-by: Suman Anna <s-anna@ti.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 08e9cc40

drivers/cpufreq/ti-cpufreq.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -226,7 +226,7 @@ static int ti_cpufreq_probe(struct platform_device *pdev)
		opp_data->cpu_dev = get_cpu_device(0);
		if (!opp_data->cpu_dev) {
		pr_err("%s: Failed to get device for CPU0\n", __func__);
		ret = ENODEV;
		ret = -ENODEV;
		goto free_opp_data;
		}