Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e5ab4766 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

MIPS: generic/yamon-dt: fix uninitialized variable error 



[ Upstream commit 255e51da15baed47531beefd02f222e4dc01f1c1 ]

In the case where fw_getenv returns an error when fetching values
for ememsizea and memsize then variable phys_memsize is not assigned
a variable and will be uninitialized on a zero check of phys_memsize.
Fix this by initializing phys_memsize to zero.

Cleans up cppcheck error:
arch/mips/generic/yamon-dt.c:100:7: error: Uninitialized variable: phys_memsize [uninitvar]

Fixes: f41d2430 ("MIPS: generic/yamon-dt: Support > 256MB of RAM")
Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 12ec6932

arch/mips/generic/yamon-dt.c

+1 −1
Original line number Diff line number Diff line
@@ -81,7 +81,7 @@ static unsigned int __init gen_fdt_mem_array( 
__init int yamon_dt_append_memory(void *fdt,

				  const struct yamon_mem_region *regions)

{

	unsigned long phys_memsize, memsize;

	unsigned long phys_memsize = 0, memsize;

	__be32 mem_array[2 * MAX_MEM_ARRAY_ENTRIES];

	unsigned int mem_entries;

	int i, err, mem_off;