Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e57903fd authored by Rakesh Pandit's avatar Rakesh Pandit Committed by Jens Axboe
Browse files

lightnvm: pblk: protect line bitmap while submitting meta io 



It seems pblk_dealloc_page would race against pblk_alloc_pages for
line bitmap for sector allocation.The chances are very low but might
as well protect the bitmap properly.

Signed-off-by: default avatarRakesh Pandit <rakesh@tuxera.com>
Reviewed-by: default avatarJavier González <javier@cnexlabs.com>
Signed-off-by: default avatarMatias Bjørling <m@bjorling.me>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 32c662c5

drivers/lightnvm/pblk-core.c

+2 −0
Original line number Diff line number Diff line
@@ -486,12 +486,14 @@ void pblk_dealloc_page(struct pblk *pblk, struct pblk_line *line, int nr_secs) 
	u64 addr;

	int i;



	spin_lock(&line->lock);

	addr = find_next_zero_bit(line->map_bitmap,

					pblk->lm.sec_per_line, line->cur_sec);

	line->cur_sec = addr - nr_secs;



	for (i = 0; i < nr_secs; i++, line->cur_sec--)

		WARN_ON(!test_and_clear_bit(line->cur_sec, line->map_bitmap));

	spin_unlock(&line->lock);

}



u64 __pblk_alloc_page(struct pblk *pblk, struct pblk_line *line, int nr_secs)