Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e483911f authored by Andrew Lunn's avatar Andrew Lunn Committed by David S. Miller
Browse files

net: mvneta: Fix clearing of MIB statistics 



The existing function to clear the MIB statatistics was using the
wrong address for the registers. Also, the counters would of been
cleared when the interface was brought up, not during the
probe. Fix both of these.

Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9b0cdefa

drivers/net/ethernet/marvell/mvneta.c

+7 −2
Original line number Diff line number Diff line
@@ -101,6 +101,8 @@ 
#define MVNETA_TXQ_CMD                           0x2448

#define      MVNETA_TXQ_DISABLE_SHIFT            8

#define      MVNETA_TXQ_ENABLE_MASK              0x000000ff

#define MVNETA_RX_DISCARD_FRAME_COUNT		 0x2484

#define MVNETA_OVERRUN_FRAME_COUNT		 0x2488

#define MVNETA_GMAC_CLOCK_DIVIDER                0x24f4

#define      MVNETA_GMAC_1MS_CLOCK_ENABLE        BIT(31)

#define MVNETA_ACC_MODE                          0x2500
@@ -192,7 +194,7 @@ 
#define      MVNETA_GMAC_AN_FLOW_CTRL_EN         BIT(11)

#define      MVNETA_GMAC_CONFIG_FULL_DUPLEX      BIT(12)

#define      MVNETA_GMAC_AN_DUPLEX_EN            BIT(13)

#define MVNETA_MIB_COUNTERS_BASE                 0x3080

#define MVNETA_MIB_COUNTERS_BASE                 0x3000

#define      MVNETA_MIB_LATE_COLLISION           0x7c

#define MVNETA_DA_FILT_SPEC_MCAST                0x3400

#define MVNETA_DA_FILT_OTH_MCAST                 0x3500
@@ -576,6 +578,8 @@ static void mvneta_mib_counters_clear(struct mvneta_port *pp) 
	/* Perform dummy reads from MIB counters */

	for (i = 0; i < MVNETA_MIB_LATE_COLLISION; i += 4)

		dummy = mvreg_read(pp, (MVNETA_MIB_COUNTERS_BASE + i));

	dummy = mvreg_read(pp, MVNETA_RX_DISCARD_FRAME_COUNT);

	dummy = mvreg_read(pp, MVNETA_OVERRUN_FRAME_COUNT);

}



/* Get System Network Statistics */
@@ -804,7 +808,6 @@ static void mvneta_port_up(struct mvneta_port *pp) 
	u32 q_map;



	/* Enable all initialized TXs. */

	mvneta_mib_counters_clear(pp);

	q_map = 0;

	for (queue = 0; queue < txq_number; queue++) {

		struct mvneta_tx_queue *txq = &pp->txqs[queue];
@@ -1081,6 +1084,8 @@ static void mvneta_defaults_set(struct mvneta_port *pp) 
	mvreg_write(pp, MVNETA_INTR_ENABLE,

		    (MVNETA_RXQ_INTR_ENABLE_ALL_MASK

		     | MVNETA_TXQ_INTR_ENABLE_ALL_MASK));



	mvneta_mib_counters_clear(pp);

}



/* Set max sizes for tx queues */