Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e2a8092c authored by Mike Frysinger's avatar Mike Frysinger
Browse files

Blackfin: bf537: fix excessive gpio int demuxing 



The search logic in the gpio demux walks all possible gpio blocks starting
at the specified pin.  The trouble on bf537 parts when we demux the port
F and port G mask A interrupts is that we also demux port H mask A ints.
Most of the time this isn't an issue as people don't usually use port H,
but might as well avoid it when possible.

Signed-off-by: default avatarMike Frysinger <vapier@gentoo.org>
parent dd8cb37b

arch/blackfin/mach-common/ints-priority.c

+25 −30
Original line number Diff line number Diff line
@@ -567,22 +567,41 @@ static int bfin_gpio_set_wake(struct irq_data *d, unsigned int state) 
# define bfin_gpio_set_wake NULL

#endif



static void bfin_demux_gpio_block(unsigned int irq)

{

	unsigned int gpio, mask;



	gpio = irq_to_gpio(irq);

	mask = get_gpiop_data(gpio) & get_gpiop_maska(gpio);



	while (mask) {

		if (mask & 1)

			bfin_handle_irq(irq);

		irq++;

		mask >>= 1;

	}

}



static void bfin_demux_gpio_irq(unsigned int inta_irq,

				struct irq_desc *desc)

{

	unsigned int i, gpio, mask, irq, search = 0;

	unsigned int irq;



	switch (inta_irq) {

#if defined(CONFIG_BF53x)

#if defined(BF537_FAMILY)

	case IRQ_PROG_INTA:

		irq = IRQ_PF0;

		search = 1;

		bfin_demux_gpio_block(IRQ_PF0);

		irq = IRQ_PG0;

		break;

# if defined(BF537_FAMILY) && !(defined(CONFIG_BFIN_MAC) || defined(CONFIG_BFIN_MAC_MODULE))

# if !(defined(CONFIG_BFIN_MAC) || defined(CONFIG_BFIN_MAC_MODULE))

	case IRQ_MAC_RX:

		irq = IRQ_PH0;

		break;

# endif

#elif defined(BF533_FAMILY)

	case IRQ_PROG_INTA:

		irq = IRQ_PF0;

		break;

#elif defined(BF538_FAMILY)

	case IRQ_PORTF_INTA:

		irq = IRQ_PF0;
@@ -613,31 +632,7 @@ static void bfin_demux_gpio_irq(unsigned int inta_irq, 
		return;

	}



	if (search) {

		for (i = 0; i < MAX_BLACKFIN_GPIOS; i += GPIO_BANKSIZE) {

			irq += i;



			mask = get_gpiop_data(i) & get_gpiop_maska(i);



			while (mask) {

				if (mask & 1)

					bfin_handle_irq(irq);

				irq++;

				mask >>= 1;

			}

		}

	} else {

			gpio = irq_to_gpio(irq);

			mask = get_gpiop_data(gpio) & get_gpiop_maska(gpio);



			do {

				if (mask & 1)

					bfin_handle_irq(irq);

				irq++;

				mask >>= 1;

			} while (mask);

	}



	bfin_demux_gpio_block(irq);

}



#else				/* CONFIG_BF54x */